fridtjof/qemu-cr16
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tests/functional: Use more fine-grained locking when looking for free ports

Browse source 
Currently, we have one lock that is held while a test is looking for
free ports. However, we are also using different ranges for looking
for free ports nowadays (PORTS_START is based on the PID of the process),
so instead of using only one lock, we should rather use a lock per
range instead. This should help to allow running more tests in parallel.

While we're at it, also create the lock files without executable bit
(mode is 0o777 by default).

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20250821094735.804210-1-thuth@redhat.com>
This commit is contained in:
Thomas Huth 2025-08-21 11:47:35 +02:00
parent 36fb979666
commit 0cdabf8adb
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
tests/functional/qemu_test/ports.py
View file

@ -23,8 +23,9 @@ class Ports():
PORTS_END = PORTS_START + PORTS_RANGE_SIZE
def __enter__(self):
lock_file = os.path.join(BUILD_DIR, "tests", "functional", "port_lock")
self.lock_fh = os.open(lock_file, os.O_CREAT)
lock_file = os.path.join(BUILD_DIR, "tests", "functional",
f".port_lock.{self.PORTS_START}")
self.lock_fh = os.open(lock_file, os.O_CREAT, mode=0o666)
fcntl.flock(self.lock_fh, fcntl.LOCK_EX)
return self