fridtjof/qemu-cr16
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

system/physmem: Silence warning from ubsan

Browse source 
When compiling QEMU with --enable-ubsan there is a undefined behavior
warning when running the bios-tables-test for example:

 .../system/physmem.c:3243:13: runtime error: applying non-zero offset 262144 to null pointer
    #0 0x55ac1df5fbc4 in address_space_write_rom_internal .../system/physmem.c:3243:13

The problem is that buf is indeed NULL if the function is e.g. called
with type == FLUSH_CACHE. Add a check to fix the issue.

Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20250728172545.314178-1-thuth@redhat.com>
This commit is contained in:
Thomas Huth 2025-07-28 19:25:45 +02:00
parent 7af325c23e
commit 2dbaf58bbe
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
system/physmem.c
View file

@ -3231,8 +3231,10 @@ static inline MemTxResult address_space_write_rom_internal(AddressSpace *as,
}
}
len -= l;
buf += l;
addr += l;
if (buf) {
buf += l;
}
}
return MEMTX_OK;
}