fridtjof/qemu-cr16
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chardev: close an fd on failure path

Browse source 
There are at least two failure paths, where we forget
to close an fd.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Vladimir Sementsov-Ogievskiy 2025-09-16 16:14:01 +03:00 • committed by Daniel P. Berrangé
parent 69620c091d
commit 30b123acbb
2 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
chardev/char-pty.c
View file

@ -350,6 +350,7 @@ static void char_pty_open(Chardev *chr,
close(slave_fd); close(slave_fd);
if (!qemu_set_blocking(master_fd, false, errp)) { if (!qemu_set_blocking(master_fd, false, errp)) {
close(master_fd);
return; return;
} }

1
chardev/char-serial.c
View file

@ -272,6 +272,7 @@ static void qmp_chardev_open_serial(Chardev *chr,
return; return;
} }
if (!qemu_set_blocking(fd, false, errp)) { if (!qemu_set_blocking(fd, false, errp)) {
close(fd);
return; return;
} }
tty_serial_init(fd, 115200, 'N', 8, 1); tty_serial_init(fd, 115200, 'N', 8, 1);