fridtjof/qemu-cr16
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fsdev/9p-marshal: move G_GNUC_PRINTF to header

Browse source 
v9fs_string_sprintf() is annotated with G_GNUC_PRINTF(2, 3) in
9p-marshal.c, but the prototype in fsdev/9p-marshal.h is missing the
attribute, so callers that include only the header do not get format
checking.

Move the annotation to the header and delete the duplicate in the
source file. No behavior change.

Signed-off-by: Sean Wei <me@sean.taipei>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20250613.qemu.9p.01@sean.taipei>
[CS: fix code style (max. 80 chars per line)]
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
This commit is contained in:
Sean Wei 2025-06-13 22:08:40 -04:00 • committed by Christian Schoenebeck
parent c079d3a31e
commit 44b540338a
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
fsdev/9p-marshal.c
View file

@ -27,8 +27,7 @@ void v9fs_string_free(V9fsString *str)
str->size = 0;
}
void G_GNUC_PRINTF(2, 3)
v9fs_string_sprintf(V9fsString *str, const char *fmt, ...)
void v9fs_string_sprintf(V9fsString *str, const char *fmt, ...)
{
va_list ap;

3
fsdev/9p-marshal.h
View file

@ -76,7 +76,8 @@ static inline void v9fs_string_init(V9fsString *str)
str->size = 0;
}
void v9fs_string_free(V9fsString *str);
void v9fs_string_sprintf(V9fsString *str, const char *fmt, ...);
void G_GNUC_PRINTF(2, 3) v9fs_string_sprintf(V9fsString *str, const char *fmt,
...);
void v9fs_string_copy(V9fsString *lhs, V9fsString *rhs);
#endif