fridtjof/qemu-cr16
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

qom: use ERRP_GUARD in user_creatable_complete

Browse source 
With error_propagate, the stack trace from any error_abort/fatal
usage will start from the error_propagate() call, which is largely
useless. Using ERRP_GUARD ensures the stack trace starts from
the origin that reported the error.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2025-08-01 17:39:58 +01:00
parent 6a9e81b705
commit 7249713b4f
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
qom/object_interfaces.c
View file

@ -24,13 +24,12 @@
bool user_creatable_complete(UserCreatable *uc, Error **errp)
{
UserCreatableClass *ucc = USER_CREATABLE_GET_CLASS(uc);
Error *err = NULL;
ERRP_GUARD();
if (ucc->complete) {
ucc->complete(uc, &err);
error_propagate(errp, err);
ucc->complete(uc, errp);
}
return !err;
return !*errp;
}
bool user_creatable_can_be_deleted(UserCreatable *uc)