From 769d19221e9fb02b8e6529f2f17dd3afa35fc507 Mon Sep 17 00:00:00 2001 From: Bernhard Beschow Date: Thu, 1 Jan 2026 21:51:35 +0100 Subject: [PATCH] hw/sd/sdhci: Fix TYPE_IMX_USDHC to implement sd-spec-version 3 by default MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes TYPE_FSL_IMX6UL, TYPE_FSL_IMX7, and TYPE_FSL_IMX8MP to implement version 3 of the SD specification. Note that TYPE_FSL_IMX6 already had "sd-spec-version" set accordingly and that TYPE_FSL_IMX25 correctly sets the same property to version 2 since the real hardware is an eSDHC which is the uSDHC's predecessor. Fixes: fd1e5c817964 ("sdhci: Add i.MX specific subtype of SDHCI") cc: qemu-stable Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Tested-by: BALATON Zoltan Message-ID: <20260112145418.220506-2-shentey@gmail.com> Signed-off-by: Philippe Mathieu-Daudé (cherry picked from commit 214f79fdfb43e92f6c06efb76c3ad8e932b035f8) Signed-off-by: Michael Tokarev --- hw/sd/sdhci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 89b595ce4a..09e9ebfe09 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1884,9 +1884,11 @@ static const MemoryRegionOps usdhc_mmio_ops = { static void imx_usdhc_init(Object *obj) { SDHCIState *s = SYSBUS_SDHCI(obj); + DeviceState *dev = DEVICE(obj); s->io_ops = &usdhc_mmio_ops; s->quirks = SDHCI_QUIRK_NO_BUSY_IRQ; + qdev_prop_set_uint8(dev, "sd-spec-version", 3); } /* --- qdev Samsung s3c --- */