fridtjof/qemu-cr16
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tests/functional: replace avocado process with subprocess

Browse source 
The standard python subprocess.check_call method is better than
avocado.utils.process as it doesn't require stuffing all args
into a single string.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20251003141820.85278-6-gustavo.romero@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
This commit is contained in:
Daniel P. Berrangé 2025-10-03 14:18:16 +00:00 • committed by Alex Bennée
parent aa7b1b726a
commit a0ad64c390
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tests/functional/reverse_debugging.py
View file

@ -11,6 +11,7 @@
# later. See the COPYING file in the top-level directory.
import os
import logging
from subprocess import check_output
from qemu_test import LinuxKernelTest, get_qemu_img
from qemu_test.ports import Ports
@ -100,7 +101,6 @@ class ReverseDebugging(LinuxKernelTest):
def reverse_debugging(self, shift=7, args=None):
from avocado.utils import gdb
from avocado.utils import process
logger = logging.getLogger('replay')
@ -111,8 +111,9 @@ class ReverseDebugging(LinuxKernelTest):
if qemu_img is None:
self.skipTest('Could not find "qemu-img", which is required to '
'create the temporary qcow2 image')
cmd = '%s create -f qcow2 %s 128M' % (qemu_img, image_path)
process.run(cmd)
out = check_output([qemu_img, 'create', '-f', 'qcow2', image_path, '128M'],
encoding='utf8')
logger.info("qemu-img: %s" % out)
replay_path = os.path.join(self.workdir, 'replay.bin')