From a45d83e2caee251546290ff7da0b381734cb726d Mon Sep 17 00:00:00 2001
From: fridtjof <fridtjof@das-labor.org>
Date: Fri, 15 Aug 2025 20:47:44 +0200
Subject: [PATCH] virt: add MMIO region as unimpl device for r/w logging

---
 hw/cr16c/Kconfig | 1 +
 hw/cr16c/virt.c  | 9 ++++++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/hw/cr16c/Kconfig b/hw/cr16c/Kconfig
index 6c52b8bf54..0e38a02a76 100644
--- a/hw/cr16c/Kconfig
+++ b/hw/cr16c/Kconfig
@@ -1,5 +1,6 @@
 config VIRT
     bool
+    select UNIMP
 
 config DE410
     bool
diff --git a/hw/cr16c/virt.c b/hw/cr16c/virt.c
index 6798ea0a74..225e22a486 100644
--- a/hw/cr16c/virt.c
+++ b/hw/cr16c/virt.c
@@ -2,6 +2,7 @@
 #include "cpu-qom.h"
 #include "system/address-spaces.h"
 #include "hw/boards.h"
+#include "hw/misc/unimp.h"
 #include "qapi/error.h"
 #include "qemu/units.h"
 #include "qom/object.h"
@@ -10,6 +11,7 @@ typedef struct VirtMachineState {
     MachineState parent_obj;
     CR16CCPU cpu;
     MemoryRegion flash;
+    MemoryRegion mmio_alias;
 } VirtMachineState;
 
 typedef struct VirtMachineClass {
@@ -27,9 +29,14 @@ static void virt_init(MachineState* machine)
     object_initialize_child(OBJECT(machine), "cpu", &m_state->cpu, TYPE_CR16C_CPU);
     object_property_set_bool(OBJECT(&m_state->cpu), "realized", true, &error_abort);
 
-    memory_region_init_ram(&m_state->flash, NULL, "flash", 16*MiB, &error_fatal);
+    memory_region_init_ram(&m_state->flash, NULL, "flash", 16*MiB - 64*KiB, &error_fatal);
     memory_region_add_subregion(get_system_memory(), 0, &m_state->flash);
 
+    create_unimplemented_device("mmio", 0xFF0000, 0xFFBFFF - 0xFF0000);
+    //memory_region_init_alias(&m_state->mmio_alias, NULL, "mmio_alias", &m_state->flash, 0xF0000, 0xFFFFF - 0xF0000);
+
+    create_unimplemented_device("icu", 0xFFFC00, 0xFFFFFF - 0xFFFC00); // interrupt controller unit
+
     if (machine->firmware) {
         if (!cr16c_load_firmware(&m_state->cpu, &m_state->flash, machine->firmware)) {
             exit(1);