hw/core/qdev-properties-system: Add missing return in set_drive_helper()
Currently, changing the 'drive' property of e.g. a scsi-hd object will result in an assertion failure if the aio context of the block node it's replaced with doesn't match the current aio context: > bdrv_replace_child_noperm: Assertion `bdrv_get_aio_context(old_bs) == > bdrv_get_aio_context(new_bs)' failed. The problematic scenario is already detected, but a 'return' statement was missing. Cc: qemu-stable@nongnu.org Fixes:d1a58c176a("qdev: allow setting drive property for realized device") Signed-off-by: Fiona Ebner <f.ebner@proxmox.com> Message-ID: <20250523070211.280498-1-f.ebner@proxmox.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com> (cherry picked from commiteef2dd03f9) Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
This commit is contained in:
parent
d8e6f3f885
commit
ab96ea4b4d
1 changed files with 1 additions and 0 deletions
|
|
@ -145,6 +145,7 @@ static void set_drive_helper(Object *obj, Visitor *v, const char *name,
|
|||
if (ctx != bdrv_get_aio_context(bs)) {
|
||||
error_setg(errp, "Different aio context is not supported for new "
|
||||
"node");
|
||||
return;
|
||||
}
|
||||
|
||||
blk_replace_bs(blk, bs, errp);
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue