fridtjof/qemu-cr16
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert "tcg/user: do not set exit_request gratuitously"

Browse source 
This reverts commit b422a7bff6.

The reporter says "The commit breaks go; if you run go build in a loop,
it eventually hangs uninterruptible (except -9) with a couple of zombie
children left over".

Reported-by: Andreas Schwab <schwab@suse.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-ID: <20260202091753.28459-1-pbonzini@redhat.com>
(cherry picked from commit 251a3d4ca3c961d95cd624252a178a33066455a2)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
This commit is contained in:
Paolo Bonzini 2026-02-02 10:17:53 +01:00 • committed by Michael Tokarev
parent 1af5215667
commit b5ce6809b4
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
accel/tcg/cpu-exec.c
View file

@ -751,7 +751,6 @@ static inline bool cpu_handle_exception(CPUState *cpu, int *ret)
void tcg_kick_vcpu_thread(CPUState *cpu) void tcg_kick_vcpu_thread(CPUState *cpu)
{ {
#ifndef CONFIG_USER_ONLY
/* /*
* Ensure cpu_exec will see the reason why the exit request was set. * Ensure cpu_exec will see the reason why the exit request was set.
* FIXME: this is not always needed. Other accelerators instead * FIXME: this is not always needed. Other accelerators instead
@ -759,7 +758,6 @@ void tcg_kick_vcpu_thread(CPUState *cpu)
* CPU thread; see kvm_arch_pre_run() for example. * CPU thread; see kvm_arch_pre_run() for example.
*/ */
qatomic_store_release(&cpu->exit_request, true); qatomic_store_release(&cpu->exit_request, true);
#endif
/* Ensure cpu_exec will see the exit request after TCG has exited. */ /* Ensure cpu_exec will see the exit request after TCG has exited. */
qatomic_store_release(&cpu->neg.icount_decr.u16.high, -1); qatomic_store_release(&cpu->neg.icount_decr.u16.high, -1);