fridtjof/qemu-cr16
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

linux-user: Check for EFAULT failure in nanosleep

Browse source 
target_to_host_timespec() returns an error if the memory the guest
passed us isn't actually readable.  We check for this everywhere
except the callsite in the TARGET_NR_nanosleep case, so this mistake
was caught by a Coverity heuristic.

Add the missing error checks to the calls that convert between the
host and target timespec structs.

Coverity: CID 1507104
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-ID: <20250710164355.1296648-1-peter.maydell@linaro.org>
This commit is contained in:
Peter Maydell 2025-07-10 17:43:54 +01:00 • committed by Richard Henderson
parent 6a3e132a1b
commit c4828cb850
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
linux-user/syscall.c
View file

@ -11643,10 +11643,14 @@ static abi_long do_syscall1(CPUArchState *cpu_env, int num, abi_long arg1,
case TARGET_NR_nanosleep:
{
struct timespec req, rem;
target_to_host_timespec(&req, arg1);
if (target_to_host_timespec(&req, arg1)) {
return -TARGET_EFAULT;
}
ret = get_errno(safe_nanosleep(&req, &rem));
if (is_error(ret) && arg2) {
host_to_target_timespec(arg2, &rem);
if (host_to_target_timespec(arg2, &rem)) {
return -TARGET_EFAULT;
}
}
}
return ret;