fridtjof/qemu-cr16
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

hw/display/framebuffer: Add cast to force 64x64 multiply

Browse source 
In framebuffer_update_display(), Coverity complains because we
multiply two values of type 'int' (which will be done as a 32x32
multiply and so in theory might overflow) and then add the result to
a ram_addr_t, which can be 64 bits.

4GB framebuffers are not plausible anyway, but keep Coverity happy
by adding casts which force these multiplies to be done as 64x64.

Coverity: CID 1487248
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-id: 20250710174312.1313177-1-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2025-07-10 18:43:12 +01:00
parent b10bd4bd17
commit e7b77e681f
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
hw/display/framebuffer.c
View file

@ -95,9 +95,9 @@ void framebuffer_update_display(
}
first = -1;
addr += i * src_width;
src += i * src_width;
dest += i * dest_row_pitch;
addr += (uint64_t)i * src_width;
src += (uint64_t)i * src_width;
dest += (uint64_t)i * dest_row_pitch;
snap = memory_region_snapshot_and_clear_dirty(mem, addr, src_width * rows,
DIRTY_MEMORY_VGA);