fridtjof/qemu-cr16
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ui/spice: Fix abort on macOS

Browse source 
The check is faulty because the thread variable was assigned in the main
thread while the main loop runs in a different thread on macOS.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3070
Signed-off-by: Mohamed Akram <mohd.akram@outlook.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-ID: <C87205B9-DD8F-4E53-AB5B-C8BF82EF1D16@outlook.com>
This commit is contained in:
Mohamed Akram 2025-09-29 15:42:24 +00:00 • committed by Marc-André Lureau
parent e01b61963f
commit e7ecb533ee
1 changed files with 1 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
ui/spice-core.c
View file

@ -50,8 +50,6 @@ static int spice_migration_completed;
static int spice_display_is_running;
static int spice_have_target_host;
static QemuThread me;
struct SpiceTimer {
QEMUTimer *timer;
};
@ -222,7 +220,7 @@ static void channel_event(int event, SpiceChannelEventInfo *info)
* thread and grab the BQL if so before calling qemu
* functions.
*/
bool need_lock = !qemu_thread_is_self(&me);
bool need_lock = !bql_locked();
if (need_lock) {
bql_lock();
}
@ -675,8 +673,6 @@ static void qemu_spice_init(void)
spice_wan_compression_t wan_compr;
bool seamless_migration;
qemu_thread_get_self(&me);
if (!opts) {
return;
}