4bf06bcf07
We are going to be adding more parameters, and this makes
rust unhappy:
Functions with lots of parameters are considered bad style and reduce
readability (“what does the 5th parameter mean?”). Consider grouping
some parameters into a new type.
Specifically:
error: this function has too many arguments (8/7)
--> /builds/mstredhat/qemu/build/rust/qemu-api/rust-qemu-api-tests.p/structured/bindings.inc.rs:3840:5
|
3840 | / pub fn new_bitfield_1(
3841 | | secure: std::os::raw::c_uint,
3842 | | space: std::os::raw::c_uint,
3843 | | user: std::os::raw::c_uint,
... |
3848 | | address_type: std::os::raw::c_uint,
3849 | | ) -> __BindgenBitfieldUnit<[u8; 4usize]> {
| |____________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `-D clippy::too-many-arguments` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::too_many_arguments)]`
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <e41344bd22248b0883752ef7a7c459090a3d9cfc.1752560127.git.mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
57 lines
1.6 KiB
Rust
57 lines
1.6 KiB
Rust
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
#![allow(
|
|
dead_code,
|
|
improper_ctypes_definitions,
|
|
improper_ctypes,
|
|
non_camel_case_types,
|
|
non_snake_case,
|
|
non_upper_case_globals,
|
|
unsafe_op_in_unsafe_fn,
|
|
clippy::pedantic,
|
|
clippy::restriction,
|
|
clippy::style,
|
|
clippy::missing_const_for_fn,
|
|
clippy::ptr_offset_with_cast,
|
|
clippy::useless_transmute,
|
|
clippy::missing_safety_doc,
|
|
clippy::too_many_arguments
|
|
)]
|
|
|
|
//! `bindgen`-generated declarations.
|
|
|
|
#[cfg(MESON)]
|
|
include!("bindings.inc.rs");
|
|
|
|
#[cfg(not(MESON))]
|
|
include!(concat!(env!("OUT_DIR"), "/bindings.inc.rs"));
|
|
|
|
// SAFETY: these are implemented in C; the bindings need to assert that the
|
|
// BQL is taken, either directly or via `BqlCell` and `BqlRefCell`.
|
|
// When bindings for character devices are introduced, this can be
|
|
// moved to the Opaque<> wrapper in src/chardev.rs.
|
|
unsafe impl Send for CharBackend {}
|
|
unsafe impl Sync for CharBackend {}
|
|
|
|
// SAFETY: this is a pure data struct
|
|
unsafe impl Send for CoalescedMemoryRange {}
|
|
unsafe impl Sync for CoalescedMemoryRange {}
|
|
|
|
// SAFETY: these are constants and vtables; the Send and Sync requirements
|
|
// are deferred to the unsafe callbacks that they contain
|
|
unsafe impl Send for MemoryRegionOps {}
|
|
unsafe impl Sync for MemoryRegionOps {}
|
|
|
|
unsafe impl Send for Property {}
|
|
unsafe impl Sync for Property {}
|
|
|
|
unsafe impl Send for TypeInfo {}
|
|
unsafe impl Sync for TypeInfo {}
|
|
|
|
unsafe impl Send for VMStateDescription {}
|
|
unsafe impl Sync for VMStateDescription {}
|
|
|
|
unsafe impl Send for VMStateField {}
|
|
unsafe impl Sync for VMStateField {}
|
|
|
|
unsafe impl Send for VMStateInfo {}
|
|
unsafe impl Sync for VMStateInfo {}
|