Add traits that let client cast typecast safely between object types. In particular, an upcast is compile-time guaranteed to succeed, and a YOLO C-style downcast must be marked as unsafe. The traits are based on an IsA<> trait that declares what is a subclass of what, which is an idea taken from glib-rs (https://docs.rs/glib/latest/glib/object/trait.IsA.html). The four primitives are also taken from there (https://docs.rs/glib/latest/glib/object/trait.Cast.html). However, the implementation of casting itself is a bit different and uses the Deref trait. This removes some pointer arithmetic from the pl011 device; it is also a prerequisite for the definition of methods, so that they can be invoked on all subclass structs. This will use the IsA<> trait to detect the structs that support the methods. glib also has a "monadic" casting trait which could be implemented on Option (as in https://docs.rs/glib/latest/glib/object/trait.CastNone.html) and perhaps even Result. For now I'm leaving it out, as the patch is already big enough and the benefit seems debatable. Reviewed-by: Zhao Liu <zhao1.liu@intel.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
51 lines
1.5 KiB
Rust
51 lines
1.5 KiB
Rust
// Copyright 2024 Red Hat, Inc.
|
|
// Author(s): Paolo Bonzini <pbonzini@redhat.com>
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
use std::{ffi::CStr, ptr::addr_of};
|
|
|
|
pub use bindings::{SysBusDevice, SysBusDeviceClass};
|
|
|
|
use crate::{
|
|
bindings,
|
|
cell::bql_locked,
|
|
irq::InterruptSource,
|
|
prelude::*,
|
|
qdev::{DeviceClass, DeviceState},
|
|
qom::ClassInitImpl,
|
|
};
|
|
|
|
unsafe impl ObjectType for SysBusDevice {
|
|
type Class = SysBusDeviceClass;
|
|
const TYPE_NAME: &'static CStr =
|
|
unsafe { CStr::from_bytes_with_nul_unchecked(bindings::TYPE_SYS_BUS_DEVICE) };
|
|
}
|
|
qom_isa!(SysBusDevice: DeviceState, Object);
|
|
|
|
// TODO: add SysBusDeviceImpl
|
|
impl<T> ClassInitImpl<SysBusDeviceClass> for T
|
|
where
|
|
T: ClassInitImpl<DeviceClass>,
|
|
{
|
|
fn class_init(sdc: &mut SysBusDeviceClass) {
|
|
<T as ClassInitImpl<DeviceClass>>::class_init(&mut sdc.parent_class);
|
|
}
|
|
}
|
|
|
|
impl SysBusDevice {
|
|
/// Return `self` cast to a mutable pointer, for use in calls to C code.
|
|
const fn as_mut_ptr(&self) -> *mut SysBusDevice {
|
|
addr_of!(*self) as *mut _
|
|
}
|
|
|
|
/// Expose an interrupt source outside the device as a qdev GPIO output.
|
|
/// Note that the ordering of calls to `init_irq` is important, since
|
|
/// whoever creates the sysbus device will refer to the interrupts with
|
|
/// a number that corresponds to the order of calls to `init_irq`.
|
|
pub fn init_irq(&self, irq: &InterruptSource) {
|
|
assert!(bql_locked());
|
|
unsafe {
|
|
bindings::sysbus_init_irq(self.as_mut_ptr(), irq.as_ptr());
|
|
}
|
|
}
|
|
}
|