2e54e5fda7
Starting with commitcab1398a60, SR-IOV VFs are realized as soon as pcie_sriov_pf_init() is called. Because pcie_sriov_pf_init() must be called before pcie_sriov_pf_init_vf_bar(), the VF BARs types won't be known when the VF realize function calls pcie_sriov_vf_register_bar(). This breaks the memory regions of the VFs (for instance with igbvf): $ lspci ... Region 0: Memory at 281a00000 (64-bit, prefetchable) [virtual] [size=16K] Region 3: Memory at 281a20000 (64-bit, prefetchable) [virtual] [size=16K] $ info mtree ... address-space: pci_bridge_pci_mem 0000000000000000-ffffffffffffffff (prio 0, i/o): pci_bridge_pci 0000000081a00000-0000000081a03fff (prio 1, i/o): igbvf-mmio 0000000081a20000-0000000081a23fff (prio 1, i/o): igbvf-msix and causes MMIO accesses to fail: Invalid write at addr 0x281A01520, size 4, region '(null)', reason: rejected Invalid read at addr 0x281A00C40, size 4, region '(null)', reason: rejected To fix this, VF BARs are now registered with pci_register_bar() which has a type parameter and pcie_sriov_vf_register_bar() is removed. Fixes:cab1398a60("pcie_sriov: Reuse SR-IOV VF device instances") Signed-off-by: Damien Bergamini <damien.bergamini@eviden.com> Signed-off-by: Clement Mathieu--Drif <clement.mathieu--drif@eviden.com> Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Message-ID: <20250901151314.1038020-1-clement.mathieu--drif@eviden.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
100 lines
3.3 KiB
C
100 lines
3.3 KiB
C
/*
|
|
* pcie_sriov.h:
|
|
*
|
|
* Implementation of SR/IOV emulation support.
|
|
*
|
|
* Copyright (c) 2015 Knut Omang <knut.omang@oracle.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*
|
|
*/
|
|
|
|
#ifndef QEMU_PCIE_SRIOV_H
|
|
#define QEMU_PCIE_SRIOV_H
|
|
|
|
#include "hw/pci/pci.h"
|
|
|
|
typedef struct PCIESriovPF {
|
|
uint8_t vf_bar_type[PCI_NUM_REGIONS]; /* Store type for each VF bar */
|
|
PCIDevice **vf; /* Pointer to an array of num_vfs VF devices */
|
|
bool vf_user_created; /* If VFs are created by user */
|
|
} PCIESriovPF;
|
|
|
|
typedef struct PCIESriovVF {
|
|
PCIDevice *pf; /* Pointer back to owner physical function */
|
|
uint16_t vf_number; /* Logical VF number of this function */
|
|
} PCIESriovVF;
|
|
|
|
bool pcie_sriov_pf_init(PCIDevice *dev, uint16_t offset,
|
|
const char *vfname, uint16_t vf_dev_id,
|
|
uint16_t init_vfs, uint16_t total_vfs,
|
|
uint16_t vf_offset, uint16_t vf_stride,
|
|
Error **errp);
|
|
void pcie_sriov_pf_exit(PCIDevice *dev);
|
|
|
|
/* Set up a VF bar in the SR/IOV bar area */
|
|
void pcie_sriov_pf_init_vf_bar(PCIDevice *dev, int region_num,
|
|
uint8_t type, dma_addr_t size);
|
|
|
|
/**
|
|
* pcie_sriov_pf_init_from_user_created_vfs() - Initialize PF with user-created
|
|
* VFs, adding ARI to PF
|
|
* @dev: A PCIe device being realized.
|
|
* @offset: The offset of the SR-IOV capability.
|
|
* @errp: pointer to Error*, to store an error if it happens.
|
|
*
|
|
* Initializes a PF with user-created VFs, adding the ARI extended capability to
|
|
* the PF. The VFs should call pcie_ari_init() to form an ARI device.
|
|
*
|
|
* Return: The size of added capabilities. 0 if the user did not create VFs.
|
|
* -1 if failed.
|
|
*/
|
|
int16_t pcie_sriov_pf_init_from_user_created_vfs(PCIDevice *dev,
|
|
uint16_t offset,
|
|
Error **errp);
|
|
|
|
bool pcie_sriov_register_device(PCIDevice *dev, Error **errp);
|
|
void pcie_sriov_unregister_device(PCIDevice *dev);
|
|
|
|
/*
|
|
* Default (minimal) page size support values
|
|
* as required by the SR/IOV standard:
|
|
* 0x553 << 12 = 0x553000 = 4K + 8K + 64K + 256K + 1M + 4M
|
|
*/
|
|
#define SRIOV_SUP_PGSIZE_MINREQ 0x553
|
|
|
|
/*
|
|
* Optionally add supported page sizes to the mask of supported page sizes
|
|
* Page size values are interpreted as opt_sup_pgsize << 12.
|
|
*/
|
|
void pcie_sriov_pf_add_sup_pgsize(PCIDevice *dev, uint16_t opt_sup_pgsize);
|
|
|
|
/* SR/IOV capability config write handler */
|
|
void pcie_sriov_config_write(PCIDevice *dev, uint32_t address,
|
|
uint32_t val, int len);
|
|
|
|
void pcie_sriov_pf_post_load(PCIDevice *dev);
|
|
|
|
/* Reset SR/IOV */
|
|
void pcie_sriov_pf_reset(PCIDevice *dev);
|
|
|
|
/* Get logical VF number of a VF - only valid for VFs */
|
|
uint16_t pcie_sriov_vf_number(PCIDevice *dev);
|
|
|
|
/*
|
|
* Get the physical function that owns this VF.
|
|
* Returns NULL if dev is not a virtual function
|
|
*/
|
|
PCIDevice *pcie_sriov_get_pf(PCIDevice *dev);
|
|
|
|
/*
|
|
* Get the n-th VF of this physical function - only valid for PF.
|
|
* Returns NULL if index is invalid
|
|
*/
|
|
PCIDevice *pcie_sriov_get_vf_at_index(PCIDevice *dev, int n);
|
|
|
|
/* Returns the current number of virtual functions. */
|
|
uint16_t pcie_sriov_num_vfs(PCIDevice *dev);
|
|
|
|
#endif /* QEMU_PCIE_SRIOV_H */
|