fridtjof/qemu-cr16
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
qemu-cr16/ui
History
Daniel P. Berrangé 3ac6daa9e1 ui: fix setting client_endian field defaults 
When a VNC client sends a "set pixel format" message, the
'client_endian' field will get initialized, however, it is
valid to omit this message if the client wants to use the
server's native pixel format. In the latter scenario nothing
is initializing the 'client_endian' field, so it remains set
to 0, matching neither G_LITTLE_ENDIAN nor G_BIG_ENDIAN. This
then results in pixel format conversion routines taking the
wrong code paths.

This problem existed before the 'client_be' flag was changed
into the 'client_endian' value, but the lack of initialization
meant it semantically defaulted to little endian, so only big
endian systems would potentially be exposed to incorrect pixel
translation.

The 'virt-viewer' / 'remote-viewer' apps always send a "set
pixel format" message so aren't exposed to any problems, but
the classical 'vncviewer' app will show the problem easily.

Fixes: 7ed96710e8
Reported-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2025-07-16 11:27:30 +01:00
..
icons
shader meson: do not build shaders by default 2023-10-17 15:20:53 +02:00
clipboard.c ui/clipboard: delay clipboard update when not running 2025-05-24 16:33:18 +02:00
cocoa.m ui & main loop: Redesign of system-specific main thread event handling 2024-12-31 21:21:34 +01:00
console-gl.c ui/console: remove redundant format field 2023-09-12 10:37:02 +04:00
console-priv.h ui/curses: Do not use console_select() 2024-03-20 10:27:58 +04:00
console-vc-stubs.c ui/curses: Do not use console_select() 2024-03-20 10:27:58 +04:00
console-vc.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
console.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
curses.c include: Rename sysemu/ -> system/ 2024-12-20 17:44:56 +01:00
curses_keys.h For curses display, recognize a few more control keys 2023-07-25 10:56:51 +01:00
cursor.c ui/cursor: remove cursor_get_mono_image 2024-10-03 17:26:06 +03:00
cursor_hidden.xpm
cursor_left_ptr.xpm
dbus-chardev.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
dbus-clipboard.c include: Rename sysemu/ -> system/ 2024-12-20 17:44:56 +01:00
dbus-console.c ui/dbus: on win32, allow ANONYMOUS with p2p 2025-02-03 21:15:57 +04:00
dbus-display1.xml ui/dbus: change dbus ScanoutDMABUF interface 2025-05-06 13:39:47 +04:00
dbus-error.c
dbus-listener.c ui/dbus: change dbus ScanoutDMABUF interface 2025-05-06 13:39:47 +04:00
dbus-module.c
dbus.c qom: Make InterfaceInfo[] uses const 2025-04-25 17:00:41 +02:00
dbus.h ui/dbus: win32 support 2023-06-27 17:08:56 +02:00
dmabuf.c ui/dmabuf: extend QemuDmaBuf to support multi-plane 2025-05-06 11:57:03 +04:00
egl-context.c qapi/ui: Drop temporary 'prefix' 2024-09-10 13:22:47 +02:00
egl-headless.c qapi/ui: Drop temporary 'prefix' 2024-09-10 13:22:47 +02:00
egl-helpers.c ui/gtk-egl: Render guest content with padding in fixed-scale mode 2025-05-24 17:04:09 +02:00
gtk-clipboard.c ui/gtk: warn if setting the clipboard failed 2025-05-24 16:33:17 +02:00
gtk-egl.c ui/gtk-egl: Render guest content with padding in fixed-scale mode 2025-05-24 17:04:09 +02:00
gtk-gl-area.c ui/gtk-gl-area: Render guest content with padding in fixed-scale mode 2025-05-24 17:04:00 +02:00
gtk.c ui/gtk: Consider scaling when propagating ui info 2025-05-24 17:03:50 +02:00
input-barrier.c qom: Make InterfaceInfo[] uses const 2025-04-25 17:00:41 +02:00
input-barrier.h
input-keymap.c
input-legacy.c ui/input-legacy.c: remove unused legacy qemu_add_kbd_event_handler() function 2024-11-08 11:06:42 +01:00
input-linux.c qom: Make InterfaceInfo[] uses const 2025-04-25 17:00:41 +02:00
input.c include: Rename sysemu/ -> system/ 2024-12-20 17:44:56 +01:00
kbd-state.c ui/vnc: Do not use console_select() 2024-03-20 10:27:54 +04:00
keymaps.c
keymaps.h ui: spelling fixes 2023-08-31 19:47:43 +02:00
meson.build meson: remove unnecessary dependencies from specific_ss 2025-05-12 16:08:24 +02:00
qemu-pixman.c ui/vnc: take account of client byte order in pixman format 2025-05-21 19:28:01 +01:00
qemu-x509.h
qemu.desktop
sdl2-2d.c ui+display: rename is_placeholder() -> surface_is_placeholder() 2024-06-19 12:42:03 +02:00
sdl2-gl.c ui/gtk-egl: Render guest content with padding in fixed-scale mode 2025-05-24 17:04:09 +02:00
sdl2-input.c ui/sdl2: release all modifiers 2024-09-13 20:12:16 +02:00
sdl2.c ui/sdl: Consider scaling in mouse event handling 2025-05-24 17:03:31 +02:00
shader.c
spice-app.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
spice-core.c include: Rename sysemu/ -> system/ 2024-12-20 17:44:56 +01:00
spice-display.c ui/spice: support multi plane dmabuf scanout 2025-05-06 13:40:09 +04:00
spice-input.c input: Allow to choose console with qemu_input_is_absolute 2023-10-03 15:04:56 +04:00
spice-module.c
trace-events ui/dbus: add trace for can_share_map 2024-10-14 17:34:09 +04:00
trace.h
udmabuf.c
ui-hmp-cmds.c qapi: Move include/qapi/qmp/ to include/qobject/ 2025-02-10 15:33:16 +01:00
ui-qmp-cmds.c ui/qmp-cmds: Improve two error messages 2023-11-17 10:07:52 +01:00
util.c
vdagent.c ui/vdagent: remove migration blocker 2025-05-24 16:33:18 +02:00
vgafont.h
vnc-auth-sasl.c ui: validate NUL byte padding in SASL client data more strictly 2024-10-22 13:02:31 +01:00
vnc-auth-sasl.h
vnc-auth-vencrypt.c
vnc-auth-vencrypt.h
vnc-clipboard.c ui/vnc-clipboard: fix inflate_buffer 2023-12-04 11:28:26 +04:00
vnc-enc-hextile-template.h ui/vnc-enc-hextile: Use static rather than dynamic length stack array 2023-09-04 14:57:44 +04:00
vnc-enc-hextile.c
vnc-enc-tight.c ui/vnc: fix tight palette pixel encoding for 8/16-bpp formats 2025-05-21 19:36:15 +01:00
vnc-enc-tight.h
vnc-enc-zlib.c
vnc-enc-zrle.c ui/vnc.c: replace big endian flag with byte order value 2025-05-21 19:28:01 +01:00
vnc-enc-zrle.c.inc ui: Clean up local variable shadowing 2023-09-29 08:13:57 +02:00
vnc-enc-zrle.h
vnc-enc-zywrle-template.c
vnc-enc-zywrle.h ui: spelling fixes 2023-08-31 19:47:43 +02:00
vnc-jobs.c ui/vnc.c: replace big endian flag with byte order value 2025-05-21 19:28:01 +01:00
vnc-jobs.h
vnc-palette.c ui: Clean up local variable shadowing 2023-09-29 08:13:57 +02:00
vnc-palette.h
vnc-stubs.c qemu-options: define -vnc only #ifdef CONFIG_VNC 2023-11-07 14:04:25 +04:00
vnc-ws.c
vnc-ws.h
vnc.c ui: fix setting client_endian field defaults 2025-07-16 11:27:30 +01:00
vnc.h ui/vnc: Update display update interval when VM state changes to RUNNING 2025-06-23 16:03:59 -04:00
vnc_keysym.h
win32-kbd-hook.c include: Rename sysemu/ -> system/ 2024-12-20 17:44:56 +01:00
x_keymap.c
x_keymap.h