d73415a315
clang's C11 atomic_fetch_*() functions only take a C11 atomic type
pointer argument. QEMU uses direct types (int, etc) and this causes a
compiler error when a QEMU code calls these functions in a source file
that also included <stdatomic.h> via a system header file:
$ CC=clang CXX=clang++ ./configure ... && make
../util/async.c:79:17: error: address argument to atomic operation must be a pointer to _Atomic type ('unsigned int *' invalid)
Avoid using atomic_*() names in QEMU's atomic.h since that namespace is
used by <stdatomic.h>. Prefix QEMU's APIs with 'q' so that atomic.h
and <stdatomic.h> can co-exist. I checked /usr/include on my machine and
searched GitHub for existing "qatomic_" users but there seem to be none.
This patch was generated using:
$ git grep -h -o '\<atomic\(64\)\?_[a-z0-9_]\+' include/qemu/atomic.h | \
sort -u >/tmp/changed_identifiers
$ for identifier in $(</tmp/changed_identifiers); do
sed -i "s%\<$identifier\>%q$identifier%g" \
$(git grep -I -l "\<$identifier\>")
done
I manually fixed line-wrap issues and misaligned rST tables.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200923105646.47864-1-stefanha@redhat.com>
|
||
|---|---|---|
| .. | ||
| atomics.rst | ||
| bitops.rst | ||
| blkdebug.txt | ||
| blkverify.txt | ||
| build-system.rst | ||
| clocks.rst | ||
| conf.py | ||
| decodetree.rst | ||
| fuzzing.txt | ||
| index.rst | ||
| kconfig.rst | ||
| loads-stores.rst | ||
| lockcnt.txt | ||
| memory.rst | ||
| migration.rst | ||
| multi-thread-tcg.rst | ||
| multiple-iothreads.txt | ||
| qapi-code-gen.txt | ||
| rcu.txt | ||
| replay.txt | ||
| reset.rst | ||
| s390-dasd-ipl.rst | ||
| secure-coding-practices.rst | ||
| stable-process.rst | ||
| tcg-icount.rst | ||
| tcg-plugins.rst | ||
| tcg.rst | ||
| testing.rst | ||
| tracing.txt | ||
| virtio-migration.txt | ||
| writing-qmp-commands.txt | ||