fridtjof/qemu-cr16
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
qemu-cr16/backends
History
Gavin Shan 78c8f780d3 hostmem: Apply merge property after the memory region is initialized 
The semantic change has been introduced by commit 5becdc0ab0 ("hostmem:
simplify the code for merge and dump properties") even it clarifies that
no senmatic change has been introduced. After the commit, the merge
property can be applied even the corresponding memory region isn't
initialized yet. This leads to crash dump by the following command
lines.

  # /home/gavin/sandbox/qemu.main/build/qemu-system-aarch64  \
    -accel kvm  -machine virt -cpu host                      \
    -object memory-backend-ram,id=mem-memN0,size=4096M,merge=off
    :
    qemu-system-aarch64: ../system/memory.c:2419: memory_region_get_ram_ptr: \
    Assertion `mr->ram_block' failed.

Fix it by applying the merge property only when the memory region is
initialized.

Message-ID: <20240915233117.478169-1-gshan@redhat.com>
Fixes: 5becdc0ab0 ("hostmem: simplify the code for merge and dump properties")
Reported-by: Zhenyu Zhang <zhenyzha@redhat.com>
Tested-by: Zhenyu Zhang <zhenyzha@redhat.com>
Signed-off-by: Gavin Shan <gshan@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
2024-09-24 11:33:35 +02:00
..
tpm
confidential-guest-support.c
cryptodev-builtin.c qapi/cryptodev: Rename QCryptodevBackendAlgType to *Algo, and drop prefix 2024-09-10 14:03:30 +02:00
cryptodev-hmp-cmds.c
cryptodev-lkcf.c qapi/cryptodev: Rename QCryptodevBackendAlgType to *Algo, and drop prefix 2024-09-10 14:03:30 +02:00
cryptodev-vhost-user.c qapi/cryptodev: Drop unwanted 'prefix' 2024-09-10 14:03:30 +02:00
cryptodev-vhost.c
cryptodev.c qapi/cryptodev: Rename QCryptodevBackendAlgType to *Algo, and drop prefix 2024-09-10 14:03:30 +02:00
dbus-vmstate.c
dbus-vmstate1.xml
host_iommu_device.c backends: Introduce HostIOMMUDevice abstract 2024-06-24 23:15:30 +02:00
hostmem-epc.c backends/hostmem-epc: Get rid of qemu_open_old() 2024-07-17 14:04:15 +03:00
hostmem-file.c
hostmem-memfd.c
hostmem-ram.c
hostmem-shm.c hostmem: add a new memory backend based on POSIX shm_open() 2024-07-03 18:14:06 -04:00
hostmem.c hostmem: Apply merge property after the memory region is initialized 2024-09-24 11:33:35 +02:00
iommufd.c vfio/iommufd: Implement VFIOIOMMUClass::query_dirty_bitmap support 2024-07-23 17:14:52 +02:00
Kconfig backends: Initial support for SPDM socket support 2024-07-22 20:15:42 -04:00
meson.build backends: Initial support for SPDM socket support 2024-07-22 20:15:42 -04:00
rng-builtin.c
rng-egd.c
rng-random.c backends/rng-random: Get rid of qemu_open_old() 2024-07-17 14:04:15 +03:00
rng.c
spdm-socket.c backends: Initial support for SPDM socket support 2024-07-22 20:15:42 -04:00
trace-events vfio/iommufd: Implement VFIOIOMMUClass::query_dirty_bitmap support 2024-07-23 17:14:52 +02:00
trace.h
vhost-user.c