fridtjof/qemu-cr16
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
qemu-cr16/include/qapi
History
Markus Armbruster bcb536cabe error: Kill @error_warn 
We added @error_warn some two years ago in commit 3ffef1a55c (error:
add global &error_warn destination).  It has multiple issues:

* error.h's big comment was not updated for it.

* Function contracts were not updated for it.

* ERRP_GUARD() is unaware of @error_warn, and fails to mask it from
  error_prepend() and such.  These crash on @error_warn, as pointed
  out by Akihiko Odaki.

All fixable.  However, after more than two years, we had just of 15
uses, of which the last few patches removed seven as unclean or
otherwise undesirable, adding back five elsewhere.  I didn't look
closely enough at the remaining seven to decide whether they are
desirable or not.

I don't think this feature earns its keep.  Drop it.

Thanks-to: Akihiko  Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-ID: <20250923091000.3180122-14-armbru@redhat.com>
Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
2025-10-01 08:33:24 +02:00
..
qmp qapi: Move and rename qapi/qmp/dispatch.h to qapi/qmp-registry.h 2025-02-10 15:33:29 +01:00
clone-visitor.h qapi: Do not cast function pointers 2024-05-29 12:41:56 +02:00
compat-policy.h qapi: change 'unsigned special_features' to 'uint64_t features' 2025-02-10 15:45:04 +01:00
dealloc-visitor.h
error-internal.h util/error: make func optional 2025-06-05 20:24:51 +02:00
error.h error: Kill @error_warn 2025-10-01 08:33:24 +02:00
forward-visitor.h qapi: introduce forwarding visitor 2021-07-23 18:17:17 +02:00
opts-visitor.h Move include qemu/option.h from qemu-common.h to actual users 2018-02-09 13:52:16 +01:00
qmp-event.h qapi: Eliminate indirection through qmp_event_get_func_emit() 2019-01-24 10:01:05 +01:00
qmp-registry.h qapi: change 'unsigned special_features' to 'uint64_t features' 2025-02-10 15:45:04 +01:00
qobject-input-visitor.h qapi: Move compat policy from QObject to generic visitor 2021-10-27 17:19:15 +02:00
qobject-output-visitor.h qapi: Move compat policy from QObject to generic visitor 2021-10-27 17:19:15 +02:00
string-input-visitor.h qapi: Rewrite string-input-visitor's integer and list parsing 2018-12-13 19:10:06 +01:00
string-output-visitor.h string-output-visitor: show structs as "<omitted>" 2023-12-21 22:49:28 +01:00
type-helpers.h qapi: New strv_from_str_list() 2024-03-04 07:12:40 +01:00
util.h qapi: change 'unsigned special_features' to 'uint64_t features' 2025-02-10 15:45:04 +01:00
visitor-impl.h qapi: change 'unsigned special_features' to 'uint64_t features' 2025-02-10 15:45:04 +01:00
visitor.h qapi: change 'unsigned special_features' to 'uint64_t features' 2025-02-10 15:45:04 +01:00