No description
Find a file
Peter Maydell ac1d88e9e7 target/arm: Don't get MDCR_EL2 in pmu_counter_enabled() before checking ARM_FEATURE_PMU
It doesn't make sense to read the value of MDCR_EL2 on a non-A-profile
CPU, and in fact if you try to do it we will assert:

#6  0x00007ffff4b95e96 in __GI___assert_fail
    (assertion=0x5555565a8c70 "!arm_feature(env, ARM_FEATURE_M)", file=0x5555565a6e5c "../../target/arm/helper.c", line=12600, function=0x5555565a9560 <__PRETTY_FUNCTION__.0> "arm_security_space_below_el3") at ./assert/assert.c:101
#7  0x0000555555ebf412 in arm_security_space_below_el3 (env=0x555557bc8190) at ../../target/arm/helper.c:12600
#8  0x0000555555ea6f89 in arm_is_el2_enabled (env=0x555557bc8190) at ../../target/arm/cpu.h:2595
#9  0x0000555555ea942f in arm_mdcr_el2_eff (env=0x555557bc8190) at ../../target/arm/internals.h:1512

We might call pmu_counter_enabled() on an M-profile CPU (for example
from the migration pre/post hooks in machine.c); this should always
return false because these CPUs don't set ARM_FEATURE_PMU.

Avoid the assertion by not calling arm_mdcr_el2_eff() before we
have done the early return for "PMU not present".

This fixes an assertion failure if you try to do a loadvm or
savevm for an M-profile board.

Cc: qemu-stable@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2155
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20240208153346.970021-1-peter.maydell@linaro.org
2024-02-15 11:36:42 +00:00
.github/workflows
.gitlab/issue_templates
.gitlab-ci.d ci: Update comment for migration-compat-aarch64 2024-02-07 10:51:27 +08:00
accel migration: prevent migration when VM has poisoned memory 2024-02-05 14:41:58 +08:00
audio misc: Clean up includes 2024-01-30 21:20:20 +03:00
authz
backends oslib-posix: initialize backend memory objects in parallel 2024-02-06 08:15:22 +01:00
block - LUKS support for detached headers 2024-02-12 14:13:58 +00:00
bsd-user include/qemu: Add TCGCPUOps typedef to typedefs.h 2024-01-29 21:04:10 +10:00
chardev Character device backend patches for 2024-02-12 2024-02-14 13:00:19 +00:00
common-user
configs kconfig: use "select" to enable semihosting 2024-02-09 17:52:30 +00:00
contrib virtio-gpu: Correct virgl_renderer_resource_get_info() error check 2024-02-14 06:09:33 -05:00
crypto crypto: Introduce 'detached-header' field in QCryptoBlockInfoLUKS 2024-02-09 12:50:37 +00:00
disas disas/hppa: Add disassembly for qemu specific instructions 2024-02-11 13:20:23 +01:00
docs virtio,pc,pci: features, cleanups, fixes 2024-02-14 15:45:52 +00:00
dump dump: Fix HMP dump-guest-memory -z without -R 2024-01-30 21:20:20 +03:00
ebpf
fpu
fsdev configure, meson: rename targetos to host_os 2023-12-31 09:11:29 +01:00
gdb-xml
gdbstub gdbstub: Implement catching syscalls 2024-02-09 17:52:40 +00:00
host/include
hw hw/arm/npcm7xx: Call qemu_configure_nic_device() for GMAC modules 2024-02-15 11:36:23 +00:00
include hw/arm/virt: Wire up non-secure EL2 virtual timer IRQ 2024-02-15 11:31:52 +00:00
io io: add trace event when cancelling TLS handshake 2024-02-09 12:50:31 +00:00
libdecnumber
linux-headers target/loongarch/kvm: Enable LSX/LASX extension 2024-01-25 15:25:31 +08:00
linux-user linux-user/aarch64: Choose SYNC as the preferred MTE mode 2024-02-15 11:30:44 +00:00
migration migration/multifd: Add a synchronization point for channel creation 2024-02-07 09:53:18 +08:00
monitor monitor/target: Include missing 'exec/memory.h' header 2024-02-13 10:59:25 +03:00
nbd
net net: make nb_nics and nd_table[] static in net/net.c 2024-02-02 16:23:48 +00:00
pc-bios target/hppa: Update SeaBIOS-hppa to version 16 2024-02-11 13:24:30 +01:00
plugins misc: Clean up includes 2024-01-30 21:20:20 +03:00
po
python
qapi Character device backend patches for 2024-02-12 2024-02-14 13:00:19 +00:00
qga qga/qapi-schema: Plug trivial documentation holes 2024-02-12 10:04:31 +01:00
qobject
qom target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules 2024-02-05 14:21:21 +01:00
replay Pull request 2024-01-09 10:32:23 +00:00
roms target/hppa: Update SeaBIOS-hppa to version 16 2024-02-11 13:24:30 +01:00
scripts QAPI patches patches for 2024-02-12 2024-02-13 10:54:59 +00:00
scsi configure, meson: rename targetos to host_os 2023-12-31 09:11:29 +01:00
semihosting include/exec: Change cpu_mmu_index argument to CPUState 2024-02-03 16:46:10 +10:00
stats
storage-daemon meson: remove config_targetos 2023-12-31 09:11:28 +01:00
stubs system/replay: Restrict icount to system emulation 2024-01-19 12:28:59 +01:00
subprojects userfaultfd: use 1ULL to build ioctl masks 2024-01-29 11:02:12 +08:00
system virtio,pc,pci: features, cleanups, fixes 2024-02-14 15:45:52 +00:00
target target/arm: Don't get MDCR_EL2 in pmu_counter_enabled() before checking ARM_FEATURE_PMU 2024-02-15 11:36:42 +00:00
tcg tcg/arm: Fix goto_tb for large translation blocks 2024-02-13 07:42:45 -10:00
tests tests/qtest/npcm7xx_emc-test: Connect all NICs to a backend 2024-02-15 11:36:23 +00:00
tools
trace
ui ui: drop VNC feature _MASK constants 2024-02-09 12:48:02 +00:00
util qapi: Improve documentation of file descriptor socket addresses 2024-02-12 10:04:32 +01:00
.dir-locals.el
.editorconfig
.exrc
.gdbinit
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitlab-ci.yml
.gitmodules
.gitpublish
.mailmap mailmap: Fix Stefan Weil email 2024-01-30 21:20:20 +03:00
.patchew.yml
.readthedocs.yml readthodocs: fully specify a build environment 2024-01-12 13:23:48 +00:00
.travis.yml
block.c block: Support detached LUKS header creation using qemu-img 2024-02-09 12:50:37 +00:00
blockdev-nbd.c
blockdev.c stream: Allow users to request only format driver names in backing file format 2024-01-26 11:16:58 +01:00
blockjob.c
configure configure: run plugin TCG tests again 2024-02-09 17:52:20 +00:00
COPYING
COPYING.LIB
cpu-common.c system/cpus: rename qemu_mutex_lock_iothread() to bql_lock() 2024-01-08 10:45:43 -05:00
cpu-target.c cpu-target: Include missing 'exec/memory.h' header 2024-02-13 10:59:25 +03:00
event-loop-base.c
gitdm.config
hmp-commands-info.hx docs/devel/docs: Document .hx file syntax 2024-01-15 17:12:22 +00:00
hmp-commands.hx hmp: Remove deprecated 'singlestep' command 2024-01-19 11:38:32 +01:00
iothread.c iothread: Simplify expression in qemu_in_iothread() 2024-02-13 10:59:25 +03:00
job-qmp.c
job.c
Kconfig
Kconfig.host
LICENSE
MAINTAINERS virtio,pc,pci: features, cleanups, fixes 2024-02-14 15:45:52 +00:00
Makefile Makefile: clean qemu-iotests output 2023-12-31 09:11:28 +01:00
meson.build crypto: Introduce SM4 symmetric cipher algorithm 2024-02-09 12:47:55 +00:00
meson_options.txt
module-common.c
os-posix.c qemu_init: increase NOFILE soft limit on POSIX 2024-02-09 12:47:58 +00:00
os-win32.c
page-vary-common.c
page-vary-target.c
pythondeps.toml
qemu-bridge-helper.c
qemu-edid.c
qemu-img-cmds.hx docs/devel/docs: Document .hx file syntax 2024-01-15 17:12:22 +00:00
qemu-img.c
qemu-io-cmds.c
qemu-io.c
qemu-keymap.c
qemu-nbd.c qemu-nbd: mention --tls-hostname option in qemu-nbd --help 2024-02-13 10:59:25 +03:00
qemu-options.hx qemu-options.hx: Add zoom-to-fit to option summary for gtk 2024-02-13 10:59:25 +03:00
qemu.nsi
qemu.sasl
README.rst
replication.c
trace-events
VERSION
version.rc

===========
QEMU README
===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Documentation
=============

Documentation can be found hosted online at
`<https://www.qemu.org/documentation/>`_. The documentation for the
current development version that is available at
`<https://www.qemu.org/docs/master/>`_ is generated from the ``docs/``
folder in the source tree, and is built by `Sphinx
<https://www.sphinx-doc.org/en/master/>`_.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:


.. code-block:: shell

  mkdir build
  cd build
  ../configure
  make

Additional information can also be found online via the QEMU website:

* `<https://wiki.qemu.org/Hosts/Linux>`_
* `<https://wiki.qemu.org/Hosts/Mac>`_
* `<https://wiki.qemu.org/Hosts/W32>`_


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

.. code-block:: shell

   git clone https://gitlab.com/qemu-project/qemu.git

When submitting patches, one common approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the `style section
<https://www.qemu.org/docs/master/devel/style.html>`_ of
the Developers Guide.

Additional information on submitting patches can be found online via
the QEMU website

* `<https://wiki.qemu.org/Contribute/SubmitAPatch>`_
* `<https://wiki.qemu.org/Contribute/TrivialPatches>`_

The QEMU website is also maintained under source control.

.. code-block:: shell

  git clone https://gitlab.com/qemu-project/qemu-web.git

* `<https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/>`_

A 'git-publish' utility was created to make above process less
cumbersome, and is highly recommended for making regular contributions,
or even just for sending consecutive patch series revisions. It also
requires a working 'git send-email' setup, and by default doesn't
automate everything, so you may want to go through the above steps
manually for once.

For installation instructions, please go to

*  `<https://github.com/stefanha/git-publish>`_

The workflow with 'git-publish' is:

.. code-block:: shell

  $ git checkout master -b my-feature
  $ # work on new commits, add your 'Signed-off-by' lines to each
  $ git publish

Your patch series will be sent and tagged as my-feature-v1 if you need to refer
back to it in the future.

Sending v2:

.. code-block:: shell

  $ git checkout my-feature # same topic branch
  $ # making changes to the commits (using 'git rebase', for example)
  $ git publish

Your patch series will be sent with 'v2' tag in the subject and the git tip
will be tagged as my-feature-v2.

Bug reporting
=============

The QEMU project uses GitLab issues to track bugs. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

* `<https://gitlab.com/qemu-project/qemu/-/issues>`_

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via GitLab.

For additional information on bug reporting consult:

* `<https://wiki.qemu.org/Contribute/ReportABug>`_


ChangeLog
=========

For version history and release notes, please visit
`<https://wiki.qemu.org/ChangeLog/>`_ or look at the git history for
more detailed information.


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

* `<mailto:qemu-devel@nongnu.org>`_
* `<https://lists.nongnu.org/mailman/listinfo/qemu-devel>`_
* #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

* `<https://wiki.qemu.org/Contribute/StartHere>`_