fridtjof/qemu-cr16
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

linux-user/gen-vdso: Handle fseek() failure

Browse source 
Coverity points out that we don't check for fseek() failure in gen-vdso.c,
and so we might pass -1 to malloc(). Add the error checking.

(This is a standalone executable that doesn't link against glib, so
we can't do the easy thing and use g_file_get_contents().)

Coverity: CID 1523742
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-ID: <20250710170707.1299926-2-peter.maydell@linaro.org>
This commit is contained in:
Peter Maydell 2025-07-10 18:07:06 +01:00 • committed by Richard Henderson
parent c4828cb850
commit ff3b0e8d32
1 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

11
linux-user/gen-vdso.c
View file

@ -113,9 +113,16 @@ int main(int argc, char **argv)
* We expect the vdso to be small, on the order of one page,
* therefore we do not expect a partial read.
*/
fseek(inf, 0, SEEK_END);
if (fseek(inf, 0, SEEK_END) < 0) {
goto perror_inf;
}
total_len = ftell(inf);
fseek(inf, 0, SEEK_SET);
if (total_len < 0) {
goto perror_inf;
}
if (fseek(inf, 0, SEEK_SET) < 0) {
goto perror_inf;
}
buf = malloc(total_len);
if (buf == NULL) {