fridtjof/qemu-cr16
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
qemu-cr16/hw/display
History
Exact
Honglei Huang e5628119e1 virtio-gpu: fix error handling in virgl_cmd_resource_create_blob 
Fix inverted error check in virgl_cmd_resource_create_blob() that causes
the function to return error when virtio_gpu_create_mapping_iov() succeeds.

virtio_gpu_create_mapping_iov() returns 0 on success and negative values
on error. The check 'if (!ret)' incorrectly treats success (ret=0) as an
error condition, causing the function to fail when it should succeed.

Change the condition to 'if (ret != 0)' to properly detect errors.

Fixes: 7c092f17cc ("virtio-gpu: Handle resource blob commands")
Signed-off-by: Honglei Huang <honghuan@amd.com>
Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20260113015203.3643608-2-honghuan@amd.com>
(cherry picked from commit 3560b51979577afc3ab937fd8b02597515bdfbae)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
2026-02-06 01:07:26 +03:00
..
acpi-vga-stub.c acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors 2022-11-07 14:00:29 -05:00
acpi-vga.c acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors 2022-11-07 14:00:29 -05:00
apple-gfx-mmio.m qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
apple-gfx-pci.m qom: Make InterfaceInfo[] uses const 2025-04-25 17:00:41 +02:00
apple-gfx.h include/system: Move exec/memory.h to system/memory.h 2025-04-23 14:08:21 -07:00
apple-gfx.m hw/display/apple-gfx: Replace QemuSemaphore with QemuEvent 2025-06-06 14:32:55 +02:00
artist.c qemu: Declare all load/store helper in 'qemu/bswap.h' 2025-07-15 02:56:39 -04:00
ati.c qemu: Declare all load/store helper in 'qemu/bswap.h' 2025-07-15 02:56:39 -04:00
ati_2d.c hw/display/ati: allow compiling without PIXMAN 2023-11-07 14:04:25 +04:00
ati_dbg.c ati-vga: Add 30 bit palette access register 2023-11-06 15:58:43 +04:00
ati_int.h ati-vga: Implement fallback for pixman routines 2023-11-06 15:58:45 +04:00
ati_regs.h ati-vga: Add 30 bit palette access register 2023-11-06 15:58:43 +04:00
bcm2835_fb.c hw/display/bcm2835_fb: Move inclusion of console.h to the .c file 2025-09-09 09:31:15 +02:00
bochs-display.c qom: Make InterfaceInfo[] uses const 2025-04-25 17:00:41 +02:00
cg3.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
cirrus_vga.c qom: Make InterfaceInfo[] uses const 2025-04-25 17:00:41 +02:00
cirrus_vga_internal.h hw/display/cirrus_vga: Move "isa-cirrus-vga" device into a separate file 2018-10-15 09:57:33 +02:00
cirrus_vga_isa.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
cirrus_vga_rop.h
cirrus_vga_rop2.h
dm163.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
dpcd.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
edid-generate.c edid: Fix clock of Detailed Timing Descriptor 2022-03-04 11:31:46 +01:00
edid-region.c include/system: Move exec/memory.h to system/memory.h 2025-04-23 14:08:21 -07:00
exynos4210_fimd.c hw/display/exynos4210_fimd: Account for zero length in fimd_update_memory_section() 2025-11-24 11:01:23 +00:00
framebuffer.c hw/display/framebuffer: Add cast to force 64x64 multiply 2025-08-01 16:48:50 +01:00
framebuffer.h include/system: Move exec/memory.h to system/memory.h 2025-04-23 14:08:21 -07:00
g364fb.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
i2c-ddc.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
jazz_led.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
Kconfig pvg: do not enable it on cross-architecture targets 2025-02-25 16:18:11 +01:00
macfb.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
meson.build pvg: add option to configure it out 2025-02-25 16:18:12 +01:00
next-fb.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
omap_lcdc.c hw/arm/omap: Drop useless casts from void * to pointer 2023-01-12 17:15:09 +00:00
pl110.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
pl110_template.h Replace config-time define HOST_WORDS_BIGENDIAN 2022-04-06 10:50:37 +02:00
qxl-logger.c hw/display/qxl: Pass requested buffer size to qxl_phys2virt() 2022-11-29 18:15:26 -05:00
qxl-render.c hw/display/qxl-render: fix qxl_unpack_chunks() chunk size calculation 2025-07-29 13:56:39 +02:00
qxl.c qom: Make InterfaceInfo[] uses const 2025-04-25 17:00:41 +02:00
qxl.h Replace "iothread lock" with "BQL" in comments 2024-01-08 10:45:43 -05:00
ramfb-standalone.c hw/i386: Add the ramfb romfile compatibility 2025-07-18 21:41:57 +02:00
ramfb-stubs.c ramfb: Add property to control if load the romfile 2025-07-17 12:44:57 +02:00
ramfb.c ramfb: Add property to control if load the romfile 2025-07-17 12:44:57 +02:00
sii9022.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
sm501.c hw/display/sm501: fix missing error-report.h 2025-07-29 13:56:39 +02:00
ssd0303.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
ssd0323.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
tcx.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
trace-events hw/display: add blob map/unmap trace events 2025-10-20 13:46:28 +01:00
trace.h trace: switch position of headers to what Meson requires 2020-08-21 06:18:24 -04:00
vga-access.h vga: move access helpers to separate include file 2019-09-19 10:37:46 +02:00
vga-helpers.h vga: optimize horizontal pel panning in 256-color modes 2024-01-18 10:43:14 +01:00
vga-isa.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
vga-mmio.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
vga-pci.c qom: Make InterfaceInfo[] uses const 2025-04-25 17:00:41 +02:00
vga.c qemu: Convert target_words_bigendian() to TargetInfo API 2025-07-15 02:56:39 -04:00
vga_int.h include/system: Move exec/ioport.h to system/ioport.h 2025-04-23 14:08:21 -07:00
vga_regs.h vga: sort-of implement word and double-word access modes 2024-01-18 10:43:14 +01:00
vhost-user-gpu-pci.c modules: introduces module_kconfig directive 2022-06-06 09:26:53 +02:00
vhost-user-gpu.c vhost-user: return failure if backend crash when live migration 2025-05-14 05:39:15 -04:00
vhost-user-vga.c modules: introduces module_kconfig directive 2022-06-06 09:26:53 +02:00
virtio-dmabuf.c virtio-dmabuf: Ensure UUID persistence for hash table insertion 2026-02-06 00:42:22 +03:00
virtio-gpu-base.c hw/display: Allow injection of virtio-gpu EDID name 2025-07-15 10:22:33 +04:00
virtio-gpu-gl.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
virtio-gpu-pci-gl.c modules: introduces module_kconfig directive 2022-06-06 09:26:53 +02:00
virtio-gpu-pci-rutabaga.c qom: Make InterfaceInfo[] uses const 2025-04-25 17:00:41 +02:00
virtio-gpu-pci.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
virtio-gpu-rutabaga.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
virtio-gpu-udmabuf-stubs.c virtio-gpu: splitting one extended mode guest fb into n-scanouts 2021-11-05 12:29:19 +01:00
virtio-gpu-udmabuf.c ui/egl: use DRM_FORMAT_MOD_INVALID as default modifier 2025-05-06 11:57:38 +04:00
virtio-gpu-virgl.c virtio-gpu: fix error handling in virgl_cmd_resource_create_blob 2026-02-06 01:07:26 +03:00
virtio-gpu.c migration: Fix regression of passing error_fatal into vmstate_load_state() 2025-11-03 16:04:10 -05:00
virtio-vga-gl.c modules: introduces module_kconfig directive 2022-06-06 09:26:53 +02:00
virtio-vga-rutabaga.c gfxstream + rutabaga: add initial support for gfxstream 2023-10-16 11:29:56 +04:00
virtio-vga.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
virtio-vga.h hw/display/virtio-vga: Convert TYPE_VIRTIO_VGA_BASE to 3-phase reset 2022-12-16 15:59:07 +00:00
vmware_vga.c hw/display/vmware_vga: skip automatic zero-init of large struct 2025-06-12 13:40:15 -04:00
xenfb.c hw/display/xenfb: Replace unreachable code by g_assert_not_reached() 2025-10-13 21:00:09 +02:00
xlnx_dp.c hw/display/xlnx_dp: Don't abort for unsupported graphics formats 2025-11-14 13:13:33 +00:00